Remove stripping of individual command line arguments in emcc.py. #16115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally introduced 10 years ago to work around a bug that occurred on windows vista (See 4ab1c8a). Its not clear if the bug was in cmake or in windows itself, or in the version of python. Windows Vista has been unsupported for a very long time now so I think ever attempted to verify this bug still exists would be very tricky. What is more, the underlying tools such as clang don't support this behavior so any user who suffered from this bug likely wouldn't be able ot use clang outside of emscripten. For example: ``` clang ' --version' clang: error: no such file or directory: ' --version'; did you mean '--version'? clang: error: no input files ``` I don't know of any tools that don't work like that above, so I don't see why we should be any different. The motivation for removing this now is that it came up in discussion when working on code nearby (#16087) and it seems to pointless at best and is also a compatibility issue (since it prevents the use of filenames that start or end in space).
sbc100
force-pushed
the
remove_argument_stripping
branch
from
57c3352 to
78dc4bf
Compare
kripken
approved these changes
Jan 26, 2022
I think its been many years since we have windows vista bots though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally introduced 10 years ago to work around a bug that
occurred on windows vista (See
4ab1c8a). Its not clear if the bug was
in cmake or in windows itself, or in the version of python.
Windows Vista has been unsupported for a very long time now so I think
even attempted to verify this bug still exists would be very tricky.
What is more, the underlying tools such as clang don't support this
behavior so any user who suffered from this bug likely wouldn't be
able ot use clang outside of emscripten. For example:
I don't know of any tools that don't work like that above, so I don't
see why we should be any different.
The motivation for removing this now is that it came up in discussion
when working on code nearby (#16087) and it seems to pointless at best
and incomaptiable at worst (since it prevents the use of
filenames that start or end in space).