refactor: improve 128-bit integer serialization #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@AndrewScull could you rebase this? |
Member
|
@AndrewScull This looks ready to merge to me. However, you need to fix your git signoff as the email addresses don't match. |
Contributor
Author
|
Which email does it need to match? I used the one I have connected to this github account. |
Contributor
Author
|
Oh, I see the error message now. Will update. |
Calculate the leading zero bytes with straight line integer operations instead of a looping search. This generates fewer instructions with no branching. Signed-off-by: Andrew Scull <[email protected]>
npmccallum
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the leading zero bytes with straight line integer operations instead of a looping search. This generates fewer instructions with no branching.