Skip to content

refactor: improve 128-bit integer serialization #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npmccallum merged 1 commit into from
Aug 2, 2025
Merged

refactor: improve 128-bit integer serialization #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions ciborium/src/ser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,8 @@ where
_ => {}
}

let bytes = raw.to_be_bytes();

// Skip leading zeros.
let mut slice = &bytes[..];
while !slice.is_empty() && slice[0] == 0 {
slice = &slice[1..];
}
let first_non_zero_byte = raw.leading_zeros() as usize / 8;
let slice = &raw.to_be_bytes()[first_non_zero_byte..];

self.0.push(Header::Tag(tag))?;
self.0.push(Header::Bytes(Some(slice.len())))?;
Expand Down Expand Up @@ -126,13 +121,8 @@ where
return self.serialize_u64(x);
}

let bytes = v.to_be_bytes();

// Skip leading zeros.
let mut slice = &bytes[..];
while !slice.is_empty() && slice[0] == 0 {
slice = &slice[1..];
}
let first_non_zero_byte = v.leading_zeros() as usize / 8;
let slice = &v.to_be_bytes()[first_non_zero_byte..];

self.0.push(Header::Tag(tag::BIGPOS))?;
self.0.push(Header::Bytes(Some(slice.len())))?;
Expand Down