-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXF-104025: Create and Delete service keys for Azure in GHA #165
Conversation
@@ -201,29 +201,6 @@ func TestCloudRouter2AzureCreateConnection_DIGP(t *testing.T) { | |||
assert.NotNil(t, output) | |||
} | |||
|
|||
func TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d-bhola We're still not deleting this test. It just needs to be renamed and have the path updated to max the directory name change that includes route filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy that. Only renaming the function name and the test path in the function.
This reverts commit 5326fd8.
…d environment variables
These two are not due to flaky tests: The ENV data is not correct and certain variables are not assigned. |
Then I will try passing the azure secrets in json to check if that passes the tests or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to have a follow up for the defects created from it for missing data for the tf variables in Azure tests, but that's outside of the scope of the code and can be resolved via GHA Secrets and Vault.
Approving for Fabric Global Sanity Release
Test Runs for this PR:
TestCloudRouter2AzureCreateConnection_DIGP
- PASSTestPort2AzureCreateConnection_DIGP
- Failing due to flaky test errorsTestVirtualDevice2AzureCreateConnection_DIGP
- Failing due to flaky test errorsTestCloudRouter2PortRoutingProtocolAndRouteFilterCreateConnection_DIGP
- PASS(Updated the test names and environment variables)
Updated Azure secrets in env variables:
(Updated ticket description, please refer below) -
TestPort2AzureCreateConnection_DIGP
- Due to some user error, the data needs to be updated in GHA and Vault
TestVirtualDevice2AzureCreateConnection_DIGP