Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXF-104025: Create and Delete service keys for Azure in GHA #165

Merged
merged 10 commits into from
Feb 15, 2025

Conversation

d-bhola
Copy link
Collaborator

@d-bhola d-bhola commented Feb 12, 2025

Test Runs for this PR:

  1. TestCloudRouter2AzureCreateConnection_DIGP - PASS
  2. TestPort2AzureCreateConnection_DIGP - Failing due to flaky test errors
  3. TestVirtualDevice2AzureCreateConnection_DIGP - Failing due to flaky test errors
  4. TestCloudRouter2PortRoutingProtocolAndRouteFilterCreateConnection_DIGP - PASS
    (Updated the test names and environment variables)

Updated Azure secrets in env variables:

  • TF_VAR_azure_client_id
  • TF_VAR_azure_client_secret
  • TF_VAR_azure_tenant_id
  • TF_VAR_azure_subscription_id

(Updated ticket description, please refer below) -
TestPort2AzureCreateConnection_DIGP
- Due to some user error, the data needs to be updated in GHA and Vault

TestVirtualDevice2AzureCreateConnection_DIGP

  • Due to some user error, the data needs to be updated in GHA and Vault

@d-bhola d-bhola marked this pull request as ready for review February 12, 2025 17:56
@@ -201,29 +201,6 @@ func TestCloudRouter2AzureCreateConnection_DIGP(t *testing.T) {
assert.NotNil(t, output)
}

func TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-bhola We're still not deleting this test. It just needs to be renamed and have the path updated to max the directory name change that includes route filters.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy that. Only renaming the function name and the test path in the function.

@thogarty
Copy link
Collaborator

These two are not due to flaky tests:
TestPort2AzureCreateConnection_DIGP
TestVirtualDevice2AzureCreateConnection_DIGP

The ENV data is not correct and certain variables are not assigned.

@d-bhola
Copy link
Collaborator Author

d-bhola commented Feb 15, 2025

These two are not due to flaky tests: TestPort2AzureCreateConnection_DIGP TestVirtualDevice2AzureCreateConnection_DIGP

The ENV data is not correct and certain variables are not assigned.

Then I will try passing the azure secrets in json to check if that passes the tests or not

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to have a follow up for the defects created from it for missing data for the tf variables in Azure tests, but that's outside of the scope of the code and can be resolved via GHA Secrets and Vault.

Approving for Fabric Global Sanity Release

@thogarty thogarty merged commit 216e674 into main Feb 15, 2025
2 of 7 checks passed
@thogarty thogarty deleted the CXF-104025-create-service-keys branch February 15, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants