Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missionRunResponse model to backend #1193

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

prasm313
Copy link
Contributor

MissionRunResponse.cs was made in addition to adjustments to missionRunController.cs and missionRunService.cs.

Related to this, an area column was added to the Mission History Page (as suggested in #1060).

@prasm313 prasm313 added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Nov 16, 2023
@prasm313 prasm313 self-assigned this Nov 17, 2023
@prasm313 prasm313 force-pushed the 1060-mission-history-table branch 4 times, most recently from 316d1b5 to 2a7ce33 Compare November 17, 2023 08:48
@aeshub aeshub changed the title add missionRunResponse model to backend Add missionRunResponse model to backend Nov 20, 2023
@prasm313 prasm313 force-pushed the 1060-mission-history-table branch 2 times, most recently from 0194abd to bef89a5 Compare November 23, 2023 14:58
@prasm313 prasm313 force-pushed the 1060-mission-history-table branch 3 times, most recently from c396f53 to 3d9de09 Compare November 24, 2023 13:48
@prasm313 prasm313 force-pushed the 1060-mission-history-table branch from 3d9de09 to 953c159 Compare November 24, 2023 13:48
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Additional improvement would be adding area to filters as well, but that can be done as a separate PR!

@prasm313 prasm313 merged commit 295a8c2 into equinor:main Nov 24, 2023
@prasm313 prasm313 deleted the 1060-mission-history-table branch May 13, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants