-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missionRunResponse model to backend #1193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2023
316d1b5
to
2a7ce33
Compare
0194abd
to
bef89a5
Compare
Eddasol
reviewed
Nov 24, 2023
Eddasol
reviewed
Nov 24, 2023
frontend/src/components/Pages/MissionHistoryPage/HistoricMissionCard.tsx
Show resolved
Hide resolved
Eddasol
reviewed
Nov 24, 2023
c396f53
to
3d9de09
Compare
3d9de09
to
953c159
Compare
Eddasol
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Additional improvement would be adding area to filters as well, but that can be done as a separate PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Backend related functionality
frontend
Frontend related functionality
improvement
Improvement to existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MissionRunResponse.cs was made in addition to adjustments to missionRunController.cs and missionRunService.cs.
Related to this, an area column was added to the Mission History Page (as suggested in #1060).