Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more fields required #1309

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

andchiind
Copy link
Contributor

Closes #1270

@andchiind andchiind added backend Backend related functionality database-change Will require migration labels Jan 4, 2024
@andchiind andchiind self-assigned this Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@andchiind andchiind marked this pull request as ready for review January 4, 2024 14:40
@andchiind
Copy link
Contributor Author

A good way to pad my line contributions

backend/api/Database/Models/Inspection.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/Inspection.cs Outdated Show resolved Hide resolved
@andchiind andchiind force-pushed the 1270-make-required branch 2 times, most recently from 23158fc to 0df9f28 Compare January 12, 2024 09:52
@andchiind andchiind requested a review from Christdej January 12, 2024 09:52
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM =)

@andchiind
Copy link
Contributor Author

andchiind commented Jan 12, 2024

/UpdateDatabase

1 similar comment
@andchiind
Copy link
Contributor Author

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind merged commit 6b24b4c into equinor:main Jan 12, 2024
12 checks passed
@andchiind andchiind deleted the 1270-make-required branch January 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the Database models for attributes which should or should not be required
2 participants