Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor front page for iphone use #1326

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Refactor front page for iphone use #1326

merged 6 commits into from
Jan 12, 2024

Conversation

mrica-equinor
Copy link
Contributor

Closes #900

@mrica-equinor mrica-equinor self-assigned this Jan 10, 2024
@mrica-equinor mrica-equinor added improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 10, 2024
@mrica-equinor mrica-equinor requested a review from anetteu January 10, 2024 14:23
oysand
oysand approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor mentioned this pull request Jan 11, 2024
Merged
@mrica-equinor mrica-equinor force-pushed the refactor-code-for-iphone branch 5 times, most recently from 2c7c17b to 849d0d8 Compare January 12, 2024 09:00
Eddasol
Eddasol reviewed Jan 12, 2024
View reviewed changes
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueCard.tsx
height: auto;
`

const EllipsisTypography = styled(Typography)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving elsewhere and importing as its also used in MissionRobotDisplay

Eddasol
Eddasol approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

A few comments that can be solved in a later PR:

  • Robot name becomes shorter if mission name is long
    image
  • Would prefer if the position of robot and task aligned between the cards
    image

@mrica-equinor mrica-equinor force-pushed the refactor-code-for-iphone branch from 849d0d8 to da85cab Compare January 12, 2024 10:37
@mrica-equinor
Copy link
Contributor Author

Looks good :)

A few comments that can be solved in a later PR:

  • Robot name becomes shorter if mission name is long
    image
  • Would prefer if the position of robot and task aligned between the cards
    image

This has been fixed

@mrica-equinor mrica-equinor merged commit 0503012 into equinor:main Jan 12, 2024
10 checks passed
@mrica-equinor mrica-equinor deleted the refactor-code-for-iphone branch May 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

@oysand oysand oysand approved these changes

@Eddasol Eddasol Eddasol approved these changes

@UsamaEquinorAFK UsamaEquinorAFK Awaiting requested review from UsamaEquinorAFK

@anetteu anetteu Awaiting requested review from anetteu

Assignees

@mrica-equinor mrica-equinor

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-arrange/cleanup the status fields on the ongoing mission page
5 participants
@mrica-equinor @andchiind @oysand @Eddasol @UsamaEquinorAFK