Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem of duplicate robot poses #2007

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix problem of duplicate robot poses #2007

merged 1 commit into from
Feb 3, 2025

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Feb 3, 2025 •
edited
Loading

Closes #1999

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added bug Something isn't working backend Backend related functionality labels Feb 3, 2025
@andchiind andchiind self-assigned this Feb 3, 2025
@andchiind andchiind force-pushed the 1999-best-year-of-my-life branch from e6880d4 to 0055972 Compare February 3, 2025 13:05
Eddasol
Eddasol approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind andchiind merged commit 006cad1 into equinor:main Feb 3, 2025
12 checks passed
@andchiind andchiind deleted the 1999-best-year-of-my-life branch February 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug if echo mission has two inspections selected on mission planner
2 participants
@andchiind @Eddasol