chore(ci): align test jobs with mise tasks#563
Open
einarwar wants to merge 1 commit into
Open
Conversation
Make api-unit-tests and docs-tests use the same mise-action + setup-uv pattern already established by the mypy and typescript-compile jobs in linting-and-checks.yaml, so local `mise run <task>` and CI behave identically. - Add .mise/tasks/test.toml with a test:api:unit task (cd api && uv run pytest --unit; depends on install-dependencies:api). - Rewrite api-unit-tests to use mise-action + setup-uv + mise run test:api:unit. - Rewrite docs-tests to use mise-action + setup-uv + mise run docs:build (existing task); rename misleading 'Checkout GitHub Action' step. - Drop unused CR_SECRET workflow_call input (never referenced; no caller passes it). - Move API_IMAGE env into api-integration-tests job (only consumer); rename dead WEB_IMAGE to NGINX_IMAGE in (currently disabled) web-tests to match the image actually published by publish-image.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the test jobs use the same mise-action + setup-uv +
mise run <task>pattern already established by themypyandtypescript-compilejobs inlinting-and-checks.yaml, so localmise run <task>and CI behave identically.Changes
.mise/tasks/test.tomlwith atest:api:unittask (cd api && uv run pytest --unit, depends oninstall-dependencies:api).api-unit-teststo usemise-action+setup-uv+mise run test:api:unit.docs-teststo usemise-action+setup-uv+mise run docs:build(existing task). Renamed the misleading "Checkout GitHub Action" step name and dropped the commented-outfetch-depth/iflines.CR_SECRETworkflow_callinput — it was declared but never referenced in the file, and no caller passes it.API_IMAGEenv into theapi-integration-testsjob (its only consumer).WEB_IMAGEtoNGINX_IMAGEin the (currently disabled)web-testsjob, matching the image actually published bypublish-image.yaml(ghcr.io/equinor/template-fastapi-react/nginx). Scoped to that job.Notes / out of scope
mypy/typescript-compilejobs as redundant with pre-commit, but.pre-commit-config.yamldoes not includemypyortsc— so those jobs are not redundant. Dismissed.docker pull+docker buildsteps inapi-integration-tests/web-teststodocker/build-push-action. Deferred to a follow-up PR that will also coverpublish-image.yaml.web-testsremainsif: \${{ false }}(separate cleanup item).