fix(no-callback-literal): report object, array, and template literals - #552
Merged
aladdin-add merged 1 commit intoJul 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the no-callback-literal rule so it correctly reports additional non-error “literal-like” values (object literals, array literals, and template literals) when they’re used as the first (error) argument in Node-style callbacks.
Changes:
- Update
couldBeError()to explicitly treatArrayExpression,ObjectExpression, andTemplateLiteralas not being possible Error objects. - Add test coverage to ensure the rule reports these cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/lib/rules/no-callback-literal.js | Adds invalid test cases for object, array, and template literals passed as the error argument. |
| lib/rules/no-callback-literal.js | Updates couldBeError() to return false for ArrayExpression, ObjectExpression, and TemplateLiteral, enabling reporting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
fixes regression in
no-callback-literalrule with objects, arrays and template literals.What changes did you make? (Give an overview)
added reporting on objects, arrays and template literals
Related Issues
#520 (comment).
Is there anything you'd like reviewers to focus on?