Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exitcode from invalidSyscall to illegalInstruction #134

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Jan 21, 2025

Description
Change the revert code for reserved/invalid instruction encoding from InvalidSyscall to IllegalInstruction.

@mininny mininny requested review from refcell and ImTei January 21, 2025 21:28
@mininny mininny force-pushed the feature/mininny/update-exitcode-to-illegal-inst branch from 2c3c7dd to 740e8f3 Compare January 22, 2025 20:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (f01251b) to head (740e8f3).

Files with missing lines Patch % Lines
rvgo/fast/vm.go 0.00% 3 Missing ⚠️
rvgo/slow/vm.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/mininny/audit-22     #134   +/-   ##
=========================================================
  Coverage                     60.92%   60.92%           
=========================================================
  Files                            27       27           
  Lines                          4195     4195           
=========================================================
  Hits                           2556     2556           
  Misses                         1492     1492           
  Partials                        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mininny mininny merged commit 7c4eaf6 into feature/mininny/audit-22 Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants