Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bellatrix-capella proof verification #603

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Add bellatrix-capella proof verification #603

merged 7 commits into from
Jul 16, 2024

Conversation

acolytec3
Copy link
Collaborator

@acolytec3 acolytec3 commented Jul 16, 2024 •
edited
Loading

More work towards #597

This adds verification of post-merge, pre-capella header proofs to the history network.

  • Moves proof verification to utility methods
  • - Refactor and improve unit tests for the history.validateHeader method
  • -Remove proof generation from history and move to utility methods
  • - Add client <-> client tests to test proof verification over the wire

acolytec3
acolytec3 commented Jul 16, 2024
View reviewed changes
Copy link
Collaborator Author

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix the cli/rpc stuff in the next PR

ScottyPoi
ScottyPoi approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Awesome work

@ScottyPoi ScottyPoi merged commit 68c82ee into master Jul 16, 2024
4 checks passed
@ScottyPoi ScottyPoi deleted the add-post-merge-proof-verification branch July 16, 2024 17:51
@acolytec3 acolytec3 mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottyPoi ScottyPoi ScottyPoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @ScottyPoi