Break codebase into separate pieces #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, breaks the Contract class into its own file. This has the benefit of being more modular, allowing subclassing for external modules, as well as saving memory that was previously wasted re-initializing the class on each instance creation. Fixes ethjs#3.
|
Will review, I like this a lot. Does it change the main method signatures in anyway? |
|
Nope, all external API is identical, no tests changed, all tests passing. I want this entirely so I can inherit from this to make an event-emitting subclass of your contract abstraction. |
|
Keep going on the event subclasses, that sounds great. I want to see a PR for that soon =D |
|
Oh, do you think it should just be a different export on this repo? I was making it its own repo that imports the contract file from this one. |
|
@FlySwatter oh yeah, it's own is fine |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, breaks the Contract class into its own file.
This has the benefit of being more modular, allowing subclassing for external modules, as well as saving memory that was previously wasted re-initializing the class on each instance creation.
Fixes #3.