Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibilty check small improvements #42

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

oskardudycz
Copy link
Collaborator

@oskardudycz oskardudycz commented Mar 9, 2024

Follow up to #41, #39 optimising the compatibility check with:

  • Pipelined stderr from npm run generate to skip redundant tmp file.
  • Removed -q parameter from grep, as we'd like to see errors in the pipeline to troubleshoot issues
  • Fixed accidental reference to tarball instead of the real package in the e2e compatibility sample project.

Relates to #38 #40

Read more in How to tackle compatibility issues in ECMA Script modules (and in general).

@oskardudycz oskardudycz modified the milestones: 0.5.3, 0.5.4 Mar 9, 2024
@oskardudycz oskardudycz added enhancement New feature or request CI compatibility labels Mar 9, 2024
@oskardudycz oskardudycz force-pushed the compatibilty_check_small_improvements branch from edd1f66 to c48a83a Compare March 9, 2024 10:07
Pipelined stderr from npm run generate to skip redundant tmp file.
Removed -q parameter from grep, as we'd like to see errors in pipeline to troubleshoot issues
@oskardudycz oskardudycz force-pushed the compatibilty_check_small_improvements branch from c48a83a to 8f08579 Compare March 9, 2024 10:09
@oskardudycz oskardudycz marked this pull request as ready for review March 9, 2024 10:15
@oskardudycz oskardudycz merged commit 9db4a81 into main Mar 9, 2024
1 check passed
@oskardudycz oskardudycz deleted the compatibilty_check_small_improvements branch March 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant