-
-
Notifications
You must be signed in to change notification settings - Fork 25
add Red language #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add Red language #62
Conversation
I don't get why these lines are cut out:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just looked like it was "off".
test/languages/red_test.rb
Outdated
x: 1 ; line comment 1 | ||
x: 2 ;-- line comment 2 | ||
x: 3 ;@@ line comment 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x: 1 ; line comment 1 | |
x: 2 ;-- line comment 2 | |
x: 3 ;@@ line comment 3 | |
x: 1 ; line comment 1 | |
x: 2 ;-- line comment 2 | |
x: 3 ;@@ line comment 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's intentional, but perhaps hard to deal with for the extractor. should it be seen as an extractor bug instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First line should be left anyway, but it's not. It's not "off".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, of course it is, inside a herdoc string. Sorry about that. I did not look closely enough to get the context.
@loziniak Let me know when you are happy for this to be merged (CI is failing right now) |
It seems I found a bug in extractor - #63 , so perhaps it's better to wait until this PR can be tested by CI. |
Looking at the issues |
Ok, I just replied to both of them. We can continue the discussion there and keep iterating together :) |
Added a test case similar to the one added to tokei. It includes comments inside strings, but probably that's not supported, so I'll probably delete this after checking what CI says.