Skip to content

add Red language #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add Red language #62

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dea084
add Red language
loziniak Nov 28, 2022
c7c03da
Red: comments inside strings are not ignored
loziniak Dec 18, 2022
4b1a78d
Red: try config suggested in #63
loziniak Dec 18, 2022
7221317
Red: take into account extractor limit of 10 lines
loziniak Dec 19, 2022
0c374d9
Red: extractor will clear trailing whitespace
loziniak Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/languages/red.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
!e
;\p
Red [\p-->>]\pj
Red +[\p-->>]\pj
comment [\p-->>]\pj
comment +[\p-->>]\pj
comment {\p-->>}\pj
comment +{\p-->>}\pj
43 changes: 43 additions & 0 deletions test/languages/red_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
require "test_helper"

module SnippetExtractor
module Languages
class RedTest < Minitest::Test
def test_full_example
code = <<~CODE
Red [] ; a comment

; single line comment
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3
x: 1 ; line comment 1
x: 2 ;-- line comment 2
x: 3 ;@@ line comment 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's intentional, but perhaps hard to deal with for the extractor. should it be seen as an extractor bug instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line should be left anyway, but it's not. It's not "off".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course it is, inside a herdoc string. Sorry about that. I did not look closely enough to get the context.


comment ['this
'is 'multiline
'comment]
comment {and this
as well}

function add100 [x [integer!]] [
"; this should not count as comment "
{ comment [and neither
this] }
]
CODE

expected = <<~CODE
x: 1
x: 2
x: 3
function add100 [x [integer!]] [
"; this should not count as comment "
{ comment [and neither
this] }
]
CODE

assert_equal expected, ExtractSnippet.(code, :red)
end
end
end
end