-
Notifications
You must be signed in to change notification settings - Fork 10
Feat: native transfer fees tracking #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nailed it @Jonathansumner! 😄
Just that one thing we discussed: let's bypass the lookup for the -fee
balance change for now and debug any errors we encounter where we're may be attempting to create multiple fee type balance changes for the same tx as this should never happen.
a1dbb80
to
393e7dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jonathansumner! 😄
Native Transfer Fees - Addressing #89
saveNativeFeesEvent
helper functionTransaction
entity fees method to non-null list ofCoin
typeNativeBalanceChanges
tests(shoutout to @ejfitzgerald for the sage wisdom)