Skip to content

Feat: native transfer fees tracking #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 26, 2022

Conversation

Jonathansumner
Copy link
Member

Native Transfer Fees - Addressing #89

  • Introduces saveNativeFeesEvent helper function
  • Alters Transaction entity fees method to non-null list of Coin type
  • implements rudimentary fee offset test within existing NativeBalanceChanges tests

(shoutout to @ejfitzgerald for the sage wisdom)

@Jonathansumner Jonathansumner added this to the v0.2 milestone Oct 6, 2022
@Jonathansumner Jonathansumner self-assigned this Oct 6, 2022
@Jonathansumner Jonathansumner marked this pull request as ready for review October 6, 2022 11:55
@bryanchriswhite bryanchriswhite removed this from the v0.2 milestone Oct 11, 2022
@bryanchriswhite bryanchriswhite linked an issue Oct 11, 2022 that may be closed by this pull request
Copy link

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it @Jonathansumner! 😄

Just that one thing we discussed: let's bypass the lookup for the -fee balance change for now and debug any errors we encounter where we're may be attempting to create multiple fee type balance changes for the same tx as this should never happen.

@Jonathansumner Jonathansumner force-pushed the feat/native-transfer-fees-tracking branch from a1dbb80 to 393e7dc Compare October 19, 2022 10:23
Copy link

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jonathansumner! 😄

@Jonathansumner Jonathansumner merged commit b8acc19 into main Oct 26, 2022
@Jonathansumner Jonathansumner deleted the feat/native-transfer-fees-tracking branch October 26, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account for fees in NativeBalanceChange events
2 participants