[codex] Update Spark Name registration payload format#10
Draft
reubenyap wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CSparkNameTxData::CURRENT_VERSIONfrom 1 to 2.operationTypebyte, defaulting to0for registration.Why
Firo's Spark Name registration format now serializes registration data as v2 and includes an operation type. Stack Wallet only creates registrations, so this intentionally keeps transfer fields out of the mobile library.
Review notes
This is the smallest native change needed for registration compatibility. Transfer support can be added later if mobile starts creating Spark Name transfers.
Validation
git diff --checkpasses locally, with only Windows CRLF warnings.spark_name_testsfrom a temp clone with MSYS2/UCRT; secp256k1 built, then the standalone compile stopped on missingendian.hbecause this repo's bare test target assumes POSIX/Linux headers.firoorg/flutter_libsparkmobile's Windows CMake build and linkedlibflutter_libsparkmobile.dll.