Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing offset option to from_parquet dsl function #941

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

  • Added missing offset option to from_parquet dsl function

Fixed

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.260mb +0.00%  | 819.822ms -0.68% | ±0.46% -41.66%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.978mb +0.01%   | 339.717ms -0.32% | ±0.10% -71.10%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.130mb +0.01%   | 1.037s -0.56%    | ±0.68% +181.40%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.834mb +0.00% | 1.263s +0.95%    | ±1.20% +1219.94% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.899mb +0.02%   | 34.573ms -1.11%  | ±0.94% -13.85%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.900mb +0.02%   | 432.880ms +0.76% | ±0.00% -99.63%   |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.600mb +0.00% | 66.401ms +3.39% | ±0.18% -85.70% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.641mb +0.00%  | 459.967ms -0.79% | ±0.52% +16.24%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.115mb +0.00%  | 73.200ms +0.46%  | ±0.48% -25.37%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.545mb +0.00% | 54.299ms +1.37%  | ±0.14% -93.10%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 321.756mb +0.00% | 1.494s -0.14%    | ±1.90% +619.87% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.939mb +0.00%  | 41.642ms -0.82%  | ±0.42% +143.65% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.675mb +0.00%  | 3.683ms +7.44%   | ±3.57% +1.03%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.402mb +0.00%  | 181.016ms -2.50% | ±0.73% -29.11%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.928mb +0.00%  | 18.076ms -2.40%  | ±0.63% +3.45%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.915mb +0.00%  | 1.867ms +4.73%   | ±1.14% -63.11%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.915mb +0.00%  | 1.782ms -9.77%   | ±1.89% +55.87%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.027mb +0.00%  | 2.703ms -5.23%   | ±0.91% -65.61%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.556mb +0.00%  | 14.667ms -2.32%  | ±1.20% -45.20%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.556mb +0.00%  | 14.853ms -2.42%  | ±1.44% -15.88%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.460mb +0.00%  | 1.894μs -0.64%   | ±2.53% +3.57%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.460mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.015mb +0.00%  | 12.841ms -1.78%  | ±0.44% -36.74%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.375mb +0.00% | 65.222ms -2.01%  | ±0.80% -71.66%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.076mb +0.00%  | 1.464ms -8.31%   | ±2.74% +6.89%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.423mb +0.00%  | 58.154ms -2.14%  | ±0.23% -86.72%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.177mb +0.00%  | 3.948ms -4.30%   | ±1.10% -13.14%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.538mb +0.00%  | 40.041ms -2.15%  | ±1.63% -28.59%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.539mb +0.00%  | 40.173ms -4.25%  | ±0.72% -19.41%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.538mb +0.00%  | 40.839ms -3.19%  | ±0.23% -86.65%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.901mb +0.00%  | 7.452ms -0.29%   | ±0.85% -27.76%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.460mb +0.00%  | 28.775ms -0.79%  | ±1.66% +6.58%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.460mb +0.00%  | 14.152μs +1.24%  | ±3.73% +319.96% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.460mb +0.00%  | 16.888μs +4.52%  | ±1.54% -25.44%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.403mb +0.00%  | 187.478ms -1.54% | ±0.76% +1.26%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.707mb +0.00% | 486.385ms -2.08% | ±1.27% +6.18%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.185mb +0.00%  | 252.693ms +2.16% | ±0.40% -28.66%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.118mb +0.00%  | 51.802ms -4.14%  | ±1.99% +2.18%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.958mb +0.00%  | 429.144ms -1.45% | ±1.68% +824.85% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.497mb +0.01%  | 85.328ms -1.28%  | ±0.44% -43.74%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 15ee651 into flow-php:1.x Jan 29, 2024
17 checks passed
@norberttech norberttech deleted the bug/parquet-dsl-missing-offset branch December 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant