Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing offset option to from_parquet dsl function #941

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Flow\ETL\Adapter\Parquet;

use function Flow\ETL\DSL\from_all;
use Flow\ETL\Exception\InvalidArgumentException;
use Flow\ETL\Extractor;
use Flow\ETL\Filesystem\Path;
use Flow\ETL\Loader;
Expand All @@ -24,10 +25,15 @@ function from_parquet(
array $columns = [],
Options $options = new Options(),
ByteOrder $byte_order = ByteOrder::LITTLE_ENDIAN,
?int $offset = null,
) : Extractor {
if (\is_array($uri)) {
$extractors = [];

if ($offset !== null) {
throw new InvalidArgumentException('Offset can be used only with single file path, not with pattern');
}

foreach ($uri as $filePath) {
$extractors[] = new ParquetExtractor(
$filePath,
Expand All @@ -44,7 +50,8 @@ function from_parquet(
\is_string($uri) ? Path::realpath($uri) : $uri,
$options,
$byte_order,
$columns
$columns,
$offset
);
}

Expand Down
Loading