Update nix dev env, add CI jobs to facilitate maintenance#10316
Closed
sveitser wants to merge 5 commits intofoundry-rs:masterfrom
Closed
Update nix dev env, add CI jobs to facilitate maintenance#10316sveitser wants to merge 5 commits intofoundry-rs:masterfrom
sveitser wants to merge 5 commits intofoundry-rs:masterfrom
Conversation
I would like to use the dev env provided by nix to build foundry but it's quite outdated. This PR makes it up to date and automated some of the maintenance. Use solc from nixpkgs instead of custom flake. This will at least update solc when it's updated in nixpkgs versus remaining on the same version until someone manually edits flake.nix and makes a PR. Add a CI job to ensure the nix dev env can be used to build foundry. I would like to make it possible to run all the tests too but this would requires more work to track down reasons for the invididual test failures.
sveitser
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
beeb
approved these changes
Apr 17, 2025
Contributor
beeb
left a comment
beeb
left a comment
There was a problem hiding this comment.
Nice, thanks for the update and CI job!
Contributor
Author
I think it would be good to set up a CI for it before making the flake more complex. That's also suggested in comments on #9260. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I would like to use the dev env provided by nix to build foundry but it's quite outdated. This PR makes it up to date and automates some of the maintenance.
Solution
Use solc from nixpkgs instead of custom flake. This will at least update solc when it's updated in nixpkgs versus remaining on the same solc version until someone manually edits flake.nix and makes a PR.
Add a CI job to ensure the nix dev env can be used to build foundry. I would like to make it possible to run all the tests too but this would requires more work to track down reasons for the individual test failures.
Example run of CI on my fork: https://github.com/sveitser/foundry/actions/runs/14489873502