chore: bump nix inputs and implement tikv-jemalloc-sys build fix#9848
Closed
jyap808 wants to merge 1 commit intofoundry-rs:masterfrom
Closed
chore: bump nix inputs and implement tikv-jemalloc-sys build fix#9848jyap808 wants to merge 1 commit intofoundry-rs:masterfrom
jyap808 wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
Member
|
Hi @jyap808 Thanks for your PR 👍 I would like to aggregate the proposed changes into #10485 and, as expressed in #10316 (comment), this will supersede this PR. Please join the conversation in #10485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes building on Nix/NixOS.
Bump inputs to the latest Rust toolchain.
Error:
tikv-jemalloc-sys fails to build:
Solution
Bump Nix inputs to upgrade to latest Rust 1.84.1.
Implement CFLAGS workaround NixOS/nixpkgs#370494 (comment) which is an upstream build issue for tikv-jemalloc-sys.
Builds successfully now.