fix: sqlite support #2634
Open
fix: sqlite support #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically involves setting the correct types here. Some date fields had datetime values set, which MariaDB "accepts", but won't work with the way we have setup some types for SQLite. Signed-off-by: Akhil Narang <[email protected]>
Comment on lines
+358
to
+362
| timedelta( | ||
| hours=current_workday_doc.start_time.hour, | ||
| minutes=current_workday_doc.start_time.minute, | ||
| seconds=current_workday_doc.start_time.second, | ||
| ).total_seconds(), |
Member
There was a problem hiding this comment.
what's the difference here?
Member
Author
There was a problem hiding this comment.
start_time is a datetime.time field, it won't have total_seconds(), only datetime.timedelta has that.
Member
|
Tests are failing |
Member
Author
|
Will check @RitvikSardana, something changed after I rebased, messed up the conflicts I guess, I had this commit originally made on a July clone of helpdesk 🙈. |
Member
|
A lot of changes are made in SLA since July, and relevant test cases are also added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.