Skip to content

fix(ticket-detail): Make main view scrollable with accessiblity tools #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balamurali27 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(ticket-detail): Make main view scrollable with accessiblity tools #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb90fe
fix(ticket-detail): Make main view scrollable with accessiblity tools
balamurali27 Oct 31, 2025
b2bee13
fix(ticket-scroll): Make main activity scrollable in desktop view
balamurali27 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desk/src/components/FadedScrollableDiv.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<template>
<div
<article
ref="scrollableDiv"
:style="`maskImage: ${maskStyle}`"
@scroll="updateMaskStyle"
>
<slot></slot>
</div>
</article>
Comment on lines +2 to +8
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <article> as the root element is semantically incorrect for a generic scrollable container component. The <article> tag should represent self-contained, independently distributable content. This component is used in multiple contexts (activity lists, filter controls) where <article> semantics don't apply. Consider using a more appropriate semantic tag like <section> if semantic markup is desired, or keep it as <div> since it's a generic utility component.

Copilot uses AI. Check for mistakes.
</template>
<script setup lang="ts">
import { computed, onMounted, ref } from "vue";
Expand Down
4 changes: 2 additions & 2 deletions desk/src/pages/ticket/MobileTicketAgent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</div>
</header>
<div v-if="ticket.data" class="flex flex-1 overflow-x-hidden">
<div class="flex flex-1 flex-col overflow-x-hidden">
<main class="flex flex-1 flex-col overflow-x-hidden">
<div class="flex-1 flex flex-col">
<Tabs
:modelValue="tabIndex"
Expand Down Expand Up @@ -132,7 +132,7 @@
"
/>
</div>
</div>
</main>
</div>
<AssignmentModal
v-if="ticket.data"
Expand Down
Loading