-
Notifications
You must be signed in to change notification settings - Fork 696
feat(i18n): Add translation wrappers to remaining Vue components #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bvisible
wants to merge
22
commits into
frappe:develop
Choose a base branch
from
bvisible:feat/i18n-vue-translations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3871bd6
feat(i18n): Add translation wrappers to Settings Vue components
bvisible a64c87b
feat(i18n): Add translation wrappers to more Settings Vue components
bvisible 7520d54
feat(i18n): Add translation wrappers to Settings components
bvisible 690b32b
feat(i18n): Add translation wrappers to modal components
bvisible 68ee4e1
feat(i18n): Add translation wrappers to more modal components
bvisible ea9986e
feat(i18n): Add translation wrappers to remaining modal components
bvisible 5bde5f4
feat(i18n): Add translation wrappers to page components
bvisible 461975f
feat(i18n): Add translation wrappers to ticket page components
bvisible bcad57c
feat(i18n): Add translation wrappers to more ticket page components
bvisible 1ebf179
feat(i18n): Add translation wrappers to utility components
bvisible 441351e
feat(i18n): Add translation wrappers to more utility components
bvisible 762fef2
feat(i18n): Add translations to CommentBox, DiscardButton, EmailArea …
bvisible 4d4d8ce
feat(i18n): Add translations to remaining Vue components
bvisible bc1cf54
feat(i18n): Add translations to Filter, EmailEditor, and telephony co…
bvisible b5ae086
style: Format Vue files with prettier
bvisible 610b3c6
style: Format all Vue files with prettier
bvisible 87ddcb2
fix: Add missing :mentions prop to CommentBox TextEditor
bvisible 5933258
Merge branch 'develop' into feat/i18n-vue-translations
RitvikSardana 8591681
feat(i18n): Add missing translations to Vue components
bvisible 663bc51
fix(i18n): Address PR review comments
bvisible da5cd69
feat(i18n): Add more missing translations
bvisible 9f87a52
feat(i18n): Add missing translations to remaining components
bvisible File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have you removed these defaults?
Please revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - reverted in 663bc51