fix: perm issues #2966
Merged
fix: perm issues #2966
+404
−220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2966 +/- ##
===========================================
+ Coverage 49.67% 50.08% +0.40%
===========================================
Files 124 122 -2
Lines 5401 5353 -48
===========================================
- Hits 2683 2681 -2
+ Misses 2718 2672 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sagarvora
reviewed
Feb 2, 2026
| frappe.throw(_("Please provide either saved_reply_id or saved_reply data")) | ||
| if not saved_reply: | ||
| saved_reply = frappe.get_doc("HD Saved Reply", saved_reply_id).message | ||
| def get_rendered_saved_reply(ticket_id, saved_reply_id=None): |
Contributor
There was a problem hiding this comment.
add type hints. checked by pydantic in whitelisted functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.