Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run hostile offline #399

Merged
merged 13 commits into from
Feb 18, 2025
Merged

Run hostile offline #399

merged 13 commits into from
Feb 18, 2025

Conversation

ryanjameskennedy
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy commented Feb 13, 2025 •
edited
Loading

Description

Summary of the changes made:

  • Added offline mode to hostile
  • Added script to fetch hostile index

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Tested on saureus and on strep

@ryanjameskennedy ryanjameskennedy requested a review from a team as a code owner February 13, 2025 12:29
ramsainanduri
ramsainanduri approved these changes Feb 13, 2025
View reviewed changes
Copy link

@ramsainanduri ramsainanduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the syntax, LGTM

mhkc
mhkc requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@mhkc mhkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

ryanjameskennedy
ryanjameskennedy commented Feb 17, 2025
View reviewed changes
@ryanjameskennedy ryanjameskennedy linked an issue Feb 17, 2025 that may be closed by this pull request
Hostile doesn't run offline #403
Closed
samuell
samuell reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@samuell samuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments / questions

mhkc
mhkc approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@mhkc mhkc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just make a new issue about cleaning up the configs to remove redundant parameters.

It could be done when we move the site specific configs.

@mhkc mhkc self-requested a review February 18, 2025 08:10
@ryanjameskennedy
Copy link
Collaborator Author

Looks good. Just make a new issue about cleaning up the configs to remove redundant parameters.

It could be done when we move the site specific configs.

Already done that with issue 401

mhkc
mhkc requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@mhkc mhkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, we should describe hostile in the documentation as well.

So I guess we need to describe how to enable/ disable hostile, specific installation instructions and software version.

@ryanjameskennedy
Copy link
Collaborator Author

One more thing, we should describe hostile in the documentation as well.

So I guess we need to describe how to enable/ disable hostile, specific installation instructions and software version.

No need for installation instructions because it is installed via the Makefile. Toggling info added and software versions added/updated.

@ryanjameskennedy ryanjameskennedy merged commit 22b1de0 into master Feb 18, 2025
3 checks passed
@ryanjameskennedy ryanjameskennedy deleted the run-hostile-offline branch February 18, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuell samuell samuell approved these changes

@mhkc mhkc mhkc approved these changes

@ramsainanduri ramsainanduri ramsainanduri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hostile doesn't run offline
4 participants
@ryanjameskennedy @samuell @mhkc @ramsainanduri