Skip to content

feat(nextjs): Add option to have TS sentry config files, other small fixes #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2021

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jul 30, 2021

This documents the change in getsentry/sentry-javascript#3847, which allows for TypeScript versions of sentry.server.config.js and sentry.client.config.js, by adding TypeScript versions of those files to the code blocks.

It also includes a few other small fixes:

  • Also add a Typescript version of the withSentry code snippet, both on the manual setup page and the getting started page.
  • Move the alert about not supporting the serverless target into the section about next.config.js, which is where it's relevant.
  • Remove the split between the snippet for sentry.server.config.js and sentry.client.config.js, as they were the exact same code. Instead, both filenames are listed on the snippet.
  • Add filenames to the two next.config.js snippets which were missing them.
  • Let the autoformatter do its thing.

@vercel
Copy link

vercel bot commented Jul 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/TKN6c44opcjR9cCHqBU9QWNE3AtL
✅ Preview: https://sentry-docs-git-kmclb-typescript-nextjs-config-files.sentry.dev

@lobsterkatie lobsterkatie marked this pull request as draft July 30, 2021 22:26
@lobsterkatie lobsterkatie marked this pull request as ready for review August 12, 2021 15:09
@lobsterkatie lobsterkatie changed the title feat(nextjs): Add option to have typescript sentry config files feat(nextjs): Add option to have TS sentry config files, other small fixes Aug 12, 2021
@lobsterkatie lobsterkatie merged commit 9eae648 into master Aug 12, 2021
@lobsterkatie lobsterkatie deleted the kmclb-typescript-nextjs-config-files branch August 12, 2021 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants