feat(nextjs): Allow for TypeScript user config files #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
commented
Jul 28, 2021
lobsterkatie
force-pushed
the
kmclb-nextjs-allow-typescript-config
branch
from
f185d8b to
2988be6
Compare
lobsterkatie
force-pushed
the
kmclb-nextjs-allow-typescript-config
branch
from
2988be6 to
8e910b6
Compare
kamilogorek
suggested changes
Jul 29, 2021
kamilogorek
approved these changes
Jul 30, 2021
lobsterkatie
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 12, 2021
…fixes (#3960) This documents the change in getsentry/sentry-javascript#3847, which allows for TypeScript versions of `sentry.server.config.js` and `sentry.client.config.js`, by adding TypeScript versions of those files to the code blocks. It also includes a few other small fixes: - Also add a Typescript version of the `withSentry` code snippet, both on the manual setup page and the getting started page. - Move the alert about not supporting the `serverless` target into the section about `next.config.js`, which is where it's relevant. - Remove the split between the snippet for `sentry.server.config.js` and `sentry.client.config.js`, as they were the exact same code. Instead, both filenames are listed on the snippet. - Add filenames to the two `next.config.js` snippets which were missing them. - Let the autoformatter do its thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're no longer dynamically requiring the user's SDK server config file and instead injecting it into the relevant bundles using webpack, there's no requirement that it be in vanilla JS, because injecting it directly into the bundles means that it will go through the full transpilation process right along with all the rest of the user's code.
This PR changes the config code to look for either a TS or JS config file, for both server and client config. (In other words, instead of just looking for
sentry.server.config.jsandsentry.client.config.js, we now also can findsentry.server.config.tsandsentry.client.config.tsif they're present instead.)UPDATE: Docs are here: getsentry/sentry-docs#3960.
Fixes #3500