-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(remix)!: Drop support for Remix v1 #14988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkan
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Added a few minor comments.
packages/remix/test/integration/test/client/errorboundary.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Onur Temizkan <[email protected]>
Co-authored-by: Onur Temizkan <[email protected]>
chargome
commented
Jan 17, 2025
packages/remix/test/integration/test/client/utils/helpers.ts
Dismissed
Show dismissed
Hide dismissed
lforst
approved these changes
Jan 17, 2025
chargome
added a commit
that referenced
this pull request
Jan 20, 2025
- Updates the label for remix integration tests. - Updates client types for captureRemixServerException params Follow up to #14988 --------- Co-authored-by: Francesco Gringl-Novy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ##14263