test(replay): Test against CDN bundles in Playwright integration tests #6770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
approved these changes
Jan 13, 2023
mydea
approved these changes
Jan 16, 2023
Lms24
force-pushed
the
lms-replay-playwright-bundles
branch
2 times, most recently
from
98c7072 to
eac2c75
Compare
Lms24
force-pushed
the
lms-replay-playwright-bundles
branch
from
eac2c75 to
c010750
Compare
|
Note: Depending on what we merge first, this or #6793, we should also add one integration test checking the browser+tracing+replay bundle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #6666 we now can inject integration CDN bundles into our Playwright tests. This PR builds on top of #6666 and #6735 to inject the Replay CDN bundle into our integration tests and test against them.
We still can't get rid of the skip condition at the beginning of Replay tests, as we don't have es5 bundles for replay but I think that's fine for the time being.
Furthermore, for this to work properly, Replay has to be imported from
@sentry/replay. As a result, tests that run against Replay bundles technically don't check that it is continued to be exported via@sentry/browser. Hence, I copied the basiccaptureReplaytest and left it once untouched, so we still cover importing Replay via@sentry/browser.In order to test against the minified CDN bundles (which is most important IMO), I had to exclude the
_replayvariable from being mangled from terser in our bundles, as we're trying to accesswindow.Replay._replayfrom the test. I'm fine with this change as long as it doesn't significantly blow up our bundle size but happy to look at better suggestions if necessary.closes #6613