-
-
Notifications
You must be signed in to change notification settings - Fork 344
feat(feedback): Report a Bug button #4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Report a Bug button #4378
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
Co-authored-by: Krystof Woldrich <[email protected]>
…ct-Button # Conflicts: # CHANGELOG.md
Thank you for reviewing and your feedback @krystofwoldrich 🙇
Good catch 👍 Should be fixed after 04f1a8d
Good point! Added with 7473c58
Good catch 👍 Added the border with 24b3df0 |
…ct-Button # Conflicts: # CHANGELOG.md
|
||
const showFeedbackWidget = (): void => { | ||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
const { showFeedbackWidget } = require('./FeedbackWidgetManager'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718
Co-authored-by: Krystof Woldrich <[email protected]>
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you! 🚀
Can you also add the button to the Expo Sample?
Thank you for reviewing and all the feedback Krystof 🙇
Added with 722114d |
📢 Type of change
Targeting
feedback-ui-2
branchPR Chain:
📜 Description
Implements feedback button that launches the feedback widget using the auto-injected feedback widget
The button is shown with
Sentry.showFeedbackButton()
and hidden withSentry.hideFeedbackButton()
provided that the app is wrapped (Sentry.wrap(RootComponent)
). The button can be styled like:💡 Motivation and Context
Part of #4302
💚 How did you test it?
Manual testing with the sample app
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps