-
-
Notifications
You must be signed in to change notification settings - Fork 344
feat(feedback): Theming #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Theming #4677
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
Overall, it's looking good, but I've noticed some issues with customizing the theme. We should add tests to ensure that the correct values are applied when using custom styles and custom themes. |
…nis/feedback-theme # Conflicts: # CHANGELOG.md
…ct-Button # Conflicts: # CHANGELOG.md
…nis/feedback-theme # Conflicts: # CHANGELOG.md
Thank you for all your feedback @krystofwoldrich 🙇 This should be ready for another go. Note that I now also cover the dynamic theme changes on this PR with 7a331b6 as part of the refactoring discussed above.
I've added snapshot tests to cover this with 6c63d03 |
Looks and works great! Reacts to the changes live. However, in the tests, only the custom dark and light scheme is checked. Can you also add a test for the system theme option, to check that the correct scheme is used, and a test for the live change if possible? |
# Conflicts: # CHANGELOG.md # packages/core/src/js/feedback/FeedbackButton.tsx # packages/core/src/js/feedback/FeedbackWidget.styles.ts # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/integration.ts # packages/core/test/feedback/FeedbackButton.test.tsx # packages/core/test/feedback/FeedbackWidgetManager.test.tsx # packages/core/test/feedback/__snapshots__/FeedbackButton.test.tsx.snap
Thank you for your feedback @krystofwoldrich 🙇
Added test for the system theme option with ba98685 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the extra tests!
📢 Type of change
Based on feat(feedback): Report a Bug button
PR Chain:
📜 Description
Adds theming options similar to JS
Demo Video
Screen.Recording.2025-03-28.at.3.42.32.PM.mov
💡 Motivation and Context
💚 How did you test it?
Sample app
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps