ref(releases): safe remove new_group column from release model #88046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
michellewzhang
force-pushed
the
mz/migrate-release-new-group-1
branch
from
20faa96 to
f6db937
Compare
|
This PR has a migration; here is the generated SQL for --
-- Alter field new_groups on release
--
ALTER TABLE "sentry_release" ALTER COLUMN "new_groups" DROP NOT NULL;
--
-- Moved release.new_groups field to pending deletion state
--
-- (no-op) |
wedamija
approved these changes
Mar 26, 2025
cmanallen
approved these changes
Mar 27, 2025
michellewzhang
added a commit
that referenced
this pull request
Mar 27, 2025
- followup from - #88024 - #88046 - relates to #87322 - [notion doc](https://www.notion.so/sentry/Removing-new_groups-field-from-Release-model-1c28b10e4b5d801d8598dd15e7a5b215?showMoveTo=true&saveParent=true) for context & plan the `new_groups` field on the `Release` model was deprecated a long time ago: https://github.com/getsentry/sentry/blob/b88166941846ce4fdb4e2001453e421b41ba7e10/src/sentry/models/release.py#L210-L211
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
- followup from - #88024 - #88046 - relates to #87322 - [notion doc](https://www.notion.so/sentry/Removing-new_groups-field-from-Release-model-1c28b10e4b5d801d8598dd15e7a5b215?showMoveTo=true&saveParent=true) for context & plan the `new_groups` field on the `Release` model was deprecated a long time ago: https://github.com/getsentry/sentry/blob/b88166941846ce4fdb4e2001453e421b41ba7e10/src/sentry/models/release.py#L210-L211
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/releases/meta/has incorrect count fornewGroups#87322the
new_groupsfield on theReleasemodel was deprecated a long time ago:sentry/src/sentry/models/release.py
Lines 210 to 211 in b881669