Improve registry storage assertions#9722
Open
andyleiserson wants to merge 3 commits into
Open
Conversation
ErichDonGubler
approved these changes
Jun 23, 2026
| self.kind, id | ||
| epoch, | ||
| storage_epoch, | ||
| "Cannot get {id:?}, found other resource {other:?}", |
Member
There was a problem hiding this comment.
nitpick(non-blocking): I wonder if it would be helpful to mention that it's the epoch that doesn't match?
This feedback applies in other places, too.
Member
There was a problem hiding this comment.
praise: It'll be nice to be able to see the other resource's full ID in diagnostic output!
| #[cfg(test)] | ||
| impl Marker for () {} | ||
| impl Marker for () { | ||
| const TYPE: &'static str = "Untyped"; |
Member
There was a problem hiding this comment.
nitpick(non-blocking): This is an edge-case that doesn't seem significant, but I wonder how confusing this would be with a macro-implemented Untyped type. 🙃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debugging a Firefox bug, I noticed that
Storage::insertrejects attempts to insert the same resource ID twice, but silently drops(index, epoch1)if asked to insert(index, epoch2). This PR disallows that, and logs more information about expected / found IDs in several of the assertions.Fixes #9685.
Testing
Claude wrote me some tests to sanity-check what the messages looked like, which I've included. They seem a little silly as permanent tests, on the other hand, I did add one for the "silently replace object in different epoch" case that was missed before.
Squash or Rebase? Squash