Skip to content

Fix naga immediate_slots_required and panic when var<immediate> size overflows 256 bytes#9725

Open
beicause wants to merge 5 commits into
gfx-rs:trunkfrom
beicause:fix-naga-immediate-slots-required
Open

Fix naga immediate_slots_required and panic when var<immediate> size overflows 256 bytes#9725
beicause wants to merge 5 commits into
gfx-rs:trunkfrom
beicause:fix-naga-immediate-slots-required

Conversation

@beicause

Copy link
Copy Markdown
Contributor

Connections
Depends on #9711 and #9597

Immedaites issue: #8556

Description

  1. Fixes Naga immediate_slots_required calculation is incorrect #9724

  2. Fixes panic when var<immediate> is larger than 256 bytes / the bitmask overflows. And validates immediate size of pipeline auto layout.

Testing

For 1, test with CTS webgpu:api,validation,encoding,programmable,pipeline_immediate:required_slots_set:*
For 2, test with CTS webgpu:api,validation,pipeline,immediates:*.

Squash or Rebase?

Rebase

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@beicause beicause force-pushed the fix-naga-immediate-slots-required branch from 1393ae7 to 4a415f4 Compare June 23, 2026 04:14
@beicause beicause changed the title Fix naga immediate slots required Fix naga immediate_slots_required and panic when immediate size overflows 256 bytes Jun 23, 2026
@beicause beicause changed the title Fix naga immediate_slots_required and panic when immediate size overflows 256 bytes Fix naga immediate_slots_required and panic when var<immediate> size overflows 256 bytes Jun 23, 2026
@beicause beicause force-pushed the fix-naga-immediate-slots-required branch from 4a415f4 to e4be672 Compare June 23, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naga immediate_slots_required calculation is incorrect

1 participant