Fix naga immediate_slots_required and panic when var<immediate> size overflows 256 bytes#9725
Open
beicause wants to merge 5 commits into
Open
Fix naga immediate_slots_required and panic when var<immediate> size overflows 256 bytes#9725beicause wants to merge 5 commits into
immediate_slots_required and panic when var<immediate> size overflows 256 bytes#9725beicause wants to merge 5 commits into
Conversation
…n there are multiple immediate variables
1393ae7 to
4a415f4
Compare
immediate_slots_required and panic when immediate size overflows 256 bytes
immediate_slots_required and panic when immediate size overflows 256 bytesimmediate_slots_required and panic when var<immediate> size overflows 256 bytes
4a415f4 to
e4be672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Depends on #9711 and #9597
Immedaites issue: #8556
Description
Fixes Naga
immediate_slots_requiredcalculation is incorrect #9724Fixes panic when
var<immediate>is larger than 256 bytes / the bitmask overflows. And validates immediate size of pipeline auto layout.Testing
For 1, test with CTS
webgpu:api,validation,encoding,programmable,pipeline_immediate:required_slots_set:*For 2, test with CTS
webgpu:api,validation,pipeline,immediates:*.Squash or Rebase?
Rebase
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.