Adding UseRoaming parameter #433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwitt
reviewed
Jan 31, 2025
| @@ -281,6 +281,9 @@ Host <%= @host %> | |||
| <% if @update_host_keys != nil -%> | |||
| UpdateHostKeys <%= @update_host_keys %> | |||
| <% end -%> | |||
| <% if @use_roaming != nil -%> | |||
There was a problem hiding this comment.
should this go after user_known_hosts_file to keep in the same order as https://github.com/ghoneycutt/puppet-module-ssh/blob/main/REFERENCE.md ?
There was a problem hiding this comment.
Either way is fine. I tried to order it alphabetically but I don't know which comes first.
That said, ssh_config.erb is mostly alphabetical except the first and last entries but REFERENCE.md is seemingly random. Should we make them both alphabetical (except the first and last) so they both match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the UseRoaming parameter was removed in the v4 rewrite, commit a55f64c, and not added back in. Sorry if this was done on purpose and I'm missing context. There could be other parameters in the same boat too but this is the only one I noticed.