Skip to content

Adding UseRoaming parameter #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions templates/ssh_config.erb
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,9 @@ Host <%= @host %>
<% if @update_host_keys != nil -%>
UpdateHostKeys <%= @update_host_keys %>
<% end -%>
<% if @use_roaming != nil -%>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this go after user_known_hosts_file to keep in the same order as https://github.com/ghoneycutt/puppet-module-ssh/blob/main/REFERENCE.md ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine. I tried to order it alphabetically but I don't know which comes first.

That said, ssh_config.erb is mostly alphabetical except the first and last entries but REFERENCE.md is seemingly random. Should we make them both alphabetical (except the first and last) so they both match?

UseRoaming <%= @use_roaming %>
<% end -%>
<% if @user != nil -%>
User <%= @user %>
<% end -%>
Expand Down