-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization onboarding welcome message #20577
Conversation
window.opener.postMessage(message + "&newUser=" + newUser, `https://${window.location.hostname}`); | ||
|
||
if (newUser === "true") { | ||
localStorage.setItem("newUserOnboardingPending", newUser); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use this localStorage item as a token, which the workspace list redeems in exchange for a modal with the organization join message.
Tool: gitpod/catfood.gitpod.cloud
0e3fba2
to
3634250
Compare
I rebased the existing code and addressed two things:
The latter includes the call sites on dashboard - we literally had 6 places for adding a single field - enough is enough I guess 🙂 I did some testing in the (dedicated emulation) preview, especially around the changes (persistence of nested structs in @corneliusludmann I would appreciate if you could do a short smoke test tomorrow, happy to set up the preview again if it has been gone - just 📯 me. |
Tool: gitpod/catfood.gitpod.cloud
…ocalStorage Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
3634250
to
5ec824c
Compare
Adding some random findings as comments below while testing the org and user preferences. Not sure if every issue belongs to this PR, though. |
What's odd?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bunch of more testing, and the current version resembles the old behavior + the changes Filip did.
Really not fond of the humongous PR, but I don't know how to move forward in a timely manner. 🤷
/unhold |
@corneliusludmann nice catch! The missing value in the warning banner seems easy enough to address, but I'm not sure if we should prevent users from entering new values in the field. On one hand, we totally could prevent saving new values when the org disables it. On the other, we don't usually couple user and org settings so much, since you can have multiple orgs (both in PAYG and in Dedicated), where the other orgs might possibly respect your timeout preferences. To illustrate the user<>org settings decoupling, you can choose any editor you desire in the user settings, without it mattering if it's even supported by the org. |
Description
Adds a customizable welcome message for organization newjoiners.
Related Issue(s)
Fixes CLC-1065
How to test
Documentation
TBD
/hold