Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization onboarding welcome message #20577

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Organization onboarding welcome message #20577

merged 6 commits into from
Feb 14, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 4, 2025

Description

Adds a customizable welcome message for organization newjoiners.

image

Related Issue(s)

Fixes CLC-1065

How to test

  1. Sign up for https://ft-org-welcome-msg.preview.gitpod-dev.com/workspaces
  2. Observe the org welcome message appear
  3. Try signing out and in again, you should not see the message appear again

Documentation

TBD

/hold

window.opener.postMessage(message + "&newUser=" + newUser, `https://${window.location.hostname}`);

if (newUser === "true") {
localStorage.setItem("newUserOnboardingPending", newUser);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use this localStorage item as a token, which the workspace list redeems in exchange for a modal with the organization join message.

Tool: gitpod/catfood.gitpod.cloud
@geropl geropl force-pushed the ft/org-welcome-msg branch from 0e3fba2 to 3634250 Compare February 13, 2025 17:32
@geropl
Copy link
Member

geropl commented Feb 13, 2025

I rebased the existing code and addressed two things:

  1. the newUser parameter got replaced by a simple user.createdAt check
  2. the handling of UpdateOrganizationSettings got a complete makeover (more to come in a follow-up PR)

The latter includes the call sites on dashboard - we literally had 6 places for adding a single field - enough is enough I guess 🙂

I did some testing in the (dedicated emulation) preview, especially around the changes (persistence of nested structs in OrganizationSettings) and it all seems to work nicely.

@corneliusludmann I would appreciate if you could do a short smoke test tomorrow, happy to set up the preview again if it has been gone - just 📯 me.

@geropl geropl force-pushed the ft/org-welcome-msg branch from 3634250 to 5ec824c Compare February 14, 2025 12:19
@corneliusludmann
Copy link
Contributor

Adding some random findings as comments below while testing the org and user preferences. Not sure if every issue belongs to this PR, though.

@corneliusludmann
Copy link
Contributor

corneliusludmann commented Feb 14, 2025

image


What's odd?

  1. Timeout will not be displayed in the yellow message: "its default timeout of MISSING HERE will be used." When explicitly set the workspace in the org, then it's okay. It only happens when there is no explicit value in the org settings page.
  2. I can still edit the textfield and hit save. Sounds odd to me when I in fact the change does not have any effect.

@corneliusludmann
Copy link
Contributor

Wrong text color in light theme (low contrast). In the user settings page, the notification text color seems to be okay.

image

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bunch of more testing, and the current version resembles the old behavior + the changes Filip did.

Really not fond of the humongous PR, but I don't know how to move forward in a timely manner. 🤷

@geropl
Copy link
Member

geropl commented Feb 14, 2025

/unhold

@roboquat roboquat merged commit 04f590d into main Feb 14, 2025
31 of 32 checks passed
@roboquat roboquat deleted the ft/org-welcome-msg branch February 14, 2025 13:14
@filiptronicek
Copy link
Member Author

Timeout will not be displayed in the yellow message: "its default timeout of MISSING HERE will be used." When explicitly set the workspace in the org, then it's okay. It only happens when there is no explicit value in the org settings page.

@corneliusludmann nice catch! The missing value in the warning banner seems easy enough to address, but I'm not sure if we should prevent users from entering new values in the field. On one hand, we totally could prevent saving new values when the org disables it. On the other, we don't usually couple user and org settings so much, since you can have multiple orgs (both in PAYG and in Dedicated), where the other orgs might possibly respect your timeout preferences.

To illustrate the user<>org settings decoupling, you can choose any editor you desire in the user settings, without it mattering if it's even supported by the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants