Fix sidebar label dropdown divider#25359
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jun 19, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jun 19, 2023
| @@ -1,4 +1,4 @@ | |||
| <div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-label dropdown"> | |||
| <div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-label label-filter dropdown"> | |||
Contributor
There was a problem hiding this comment.
Don't do this. The label-filter styles will pollute this select-label dropdown.
Contributor
Author
There was a problem hiding this comment.
Thanks, changed to change selector instead in 8ec7f48
silverwind
approved these changes
Jun 19, 2023
GiteaBot
added
lgtm/done
Member
|
Can backport if #25312 also backports. |
silverwind
added
the
reviewed/wait-merge
Collaborator
|
I was unable to create a backport for 1.20. @HesterG, please send one manually. 🍵 |
GiteaBot
added
backport/manual
silverwind
removed
the
backport/manual
Member
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 21, 2023
* giteaofficial/main: Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) Fetch all git data for embedding correct version in docker image (go-gitea#25361) Fix sidebar label dropdown divider (go-gitea#25359) Fix issue filters on mobile view (go-gitea#25368) Refactor: TotalTimest return seconds (go-gitea#25370)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #25312
Also fix the label dropdown on sidebar
Before:
After: