Skip to content

Fix sidebar label dropdown divider #25359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 4 commits into from
Jun 19, 2023
Merged

Fix sidebar label dropdown divider #25359

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59581eb
fix sidebar label
HesterG Jun 19, 2023
35e10e6
Merge branch 'main' into fix-sidebar-label
HesterG Jun 19, 2023
8ec7f48
change selector
HesterG Jun 19, 2023
17d10c4
Merge branch 'main' into fix-sidebar-label
GiteaBot Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/issue/labels/labels_selector_field.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-label dropdown">
<div class="ui {{if or (not .HasIssuesOrPullsWritePermission) .Repository.IsArchived}}disabled{{end}} floating jump select-label label-filter dropdown">
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this. The label-filter styles will pollute this select-label dropdown.

Copy link
Copy Markdown
Contributor Author

@HesterG HesterG Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed to change selector instead in 8ec7f48

<span class="text gt-df gt-ac muted">
<strong>{{.locale.Tr "repo.issues.new.labels"}}</strong>
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
Expand Down