Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 instead of error when commit not exist #31977

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Return 404 instead of error when commit not exist #31977

merged 2 commits into from
Sep 5, 2024

Conversation

AdamMajer
Copy link
Contributor

Fix #31976

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 4, 2024
lafriks
lafriks requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 4, 2024
@AdamMajer AdamMajer changed the title Return 204 instead of error when commit not exist Return 404 instead of error when commit not exist Sep 5, 2024
@AdamMajer AdamMajer force-pushed the not-error-on-missing-branch branch from 0746d8d to 931de1a Compare September 5, 2024 09:24
@AdamMajer AdamMajer requested a review from lafriks September 5, 2024 09:24
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Sep 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2024
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 5, 2024
@lunny lunny merged commit bf7ae04 into go-gitea:main Sep 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Sep 5, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf074d2 
* giteaofficial/main:
  Return 404 instead of error when commit not exist (go-gitea#31977)
  For consistency make repo search sort options case sensitive (go-gitea#31951)
  Fix nuget/conan/container packages upload bugs (go-gitea#31967)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

API /repos/{owner}/{repo}/commits call error 500 on non-existent branch
5 participants
@AdamMajer @lafriks @delvh @lunny @GiteaBot