Skip to content

Fix LTO/IPO being forcefully enabled #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix LTO/IPO being forcefully enabled #2913

wants to merge 5 commits into from
+41 −11

Conversation

@davidhozic
Copy link
Contributor

@davidhozic davidhozic commented Oct 25, 2025 •
edited
Loading

Fixes #2904 .

@davidhozic davidhozic marked this pull request as ready for review October 25, 2025 13:48
@davidhozic
Copy link
Contributor Author

davidhozic commented Oct 25, 2025 •
edited
Loading

@saran-t This works as expected now.

I'm just wondering it it's okay to raise an error (FATAL_ERROR) when CMAKE_INTERPROCEDURAL_OPTIMIZATION:BOOL=ON is given instead off MUJOCO_ENABLE_IPO:BOOL=ON?
There's unfortunately no way to check if the user has set CMAKE_INTERPROCEDURAL_OPTIMIZATION to OFF however.

@davidhozic davidhozic force-pushed the fix/ipo_default_release branch from 9467cf0 to d954bfd Compare October 25, 2025 14:33
@davidhozic davidhozic mentioned this pull request Nov 1, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LTO is forcefully enabled instead of by default in the build system

1 participant

@davidhozic