Do not add Mac names when populating the fvar table #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See googlefonts/gftools#469
As of the latest Font Bakery release, the no_mac_entries check has been promoted to the Universal profile, but by default, gftools and axisregistry insert Mac names when populating STAT and fvar.
googlefonts/gftools#1077 has been merged to prevent adding Mac names to STAT, and so this PR follows up to prevent Mac names from being added to fvar too. This is already the behaviour of the in-progress Rust port of axisregistry, and so only the original Python version has been adjusted.
This is the right approach for the particular project I am looking at, but I would like to confirm that this is the right fix - as opposed to, e.g., making the Mac names opt-out - to make sure that this will not have unintended consequences for other consumers of axisregistry, for static TTFs destined for legacy environments, or similar.