Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add Mac names when populating the fvar table #187

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Do not add Mac names when populating the fvar table #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/axisregistry/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
]
)

# The platforms to include when adding records to the `name` table, which
# differs from fontTools' default.
NAME_PLATFORMS = ((3, 1, 0x409),)


def load_protobuf(klass, data):
message = klass()
Expand Down Expand Up @@ -442,9 +446,9 @@ def gen_instances(is_italic):
coordinates["slnt"] = slnt_axis.minValue

inst = NamedInstance()
inst.subfamilyNameID = name_table.addName(name)
inst.subfamilyNameID = name_table.addName(name, platforms=NAME_PLATFORMS)
inst.postscriptNameID = name_table.addName(
f"{family_name}-{name}".replace(" ", "")
f"{family_name}-{name}".replace(" ", ""), platforms=NAME_PLATFORMS
)
inst.coordinates = coordinates
log.debug(f"Adding fvar instance: {name}: {coordinates}")
Expand Down
Loading