Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Snyk vulnerabilities #1543

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Resolve Snyk vulnerabilities #1543

merged 6 commits into from
Jan 30, 2024

Conversation

davidfurey
Copy link
Member

What's changed?

Primary change is bumping Postgres and commons-text to keep Snyk happy.

At the same time I've resolved a a number of warnings (see individual commits), most notably removing the deprecated Akka Agent.

A try without a catch or finally is equivalent to putting its body in a block; no exceptions are handled.
@davidfurey davidfurey requested a review from a team as a code owner January 24, 2024 09:35
NB- ordering of withFallback is different to ++
Agent has been deprecated for a while.

DurationMetric was never used, so deleted.
@davidfurey davidfurey force-pushed the snyk-vulnerabilities branch from 125aafb to 71e0949 Compare January 24, 2024 10:30
@davidfurey
Copy link
Member Author

Deployed to CODE, seems fine

Copy link
Contributor

@Georges-GNM Georges-GNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can see this is still on code, fronts tool seems to be working as normal - looks good to me

@davidfurey davidfurey merged commit 0f9eb69 into main Jan 30, 2024
1 check passed
@davidfurey davidfurey deleted the snyk-vulnerabilities branch January 30, 2024 14:35
@prout-bot
Copy link

Seen on PROD (merged by @davidfurey 12 minutes and 16 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants