Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate metadata files for onedrive #137549

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Feb 6, 2025

Breaking change

Proposed change

OneDrive is currently broken for a lot of users, because apparently some OneDrives have a 1kB limit for the description (where the metadata of the backup is stored). That was only noticed now, because it's not there for all users and only becomes a problem if the users also have multiple addons.

This PR changes the location where the metadata is stored to a separate metadata file and only keeps the reference to the backup file in the metadata file's description. Also, we migrate all existing backups to use the new metadata files.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj added this to the 2025.2.1 milestone Feb 6, 2025
@zweckj zweckj changed the title Switch to separate metadata Use separate metadata files for onedrive Feb 6, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zweckj 👍

../Frenck

@frenck frenck force-pushed the onedrive/metadata-files branch from ae5789d to d262bba Compare February 7, 2025 14:46
@zweckj zweckj merged commit 040e1ff into home-assistant:dev Feb 7, 2025
32 checks passed
@zweckj zweckj deleted the onedrive/metadata-files branch February 7, 2025 15:06
@frenck frenck mentioned this pull request Feb 7, 2025
frenck added a commit that referenced this pull request Feb 7, 2025
* Fix hassio test using wrong fixture (#137516)

* Change Electric Kiwi authentication (#135231)

Co-authored-by: Joostlek <[email protected]>

* Update govee-ble to 0.42.1 (#137371)

* Bump holidays to 0.66 (#137449)

* Bump aiohttp-asyncmdnsresolver to 0.1.0 (#137492)

changelog: aio-libs/aiohttp-asyncmdnsresolver@v0.0.3...v0.1.0

Switches to the new AsyncDualMDNSResolver class to which
tries via mDNS and DNS for .local domains since we have
so many different user DNS configurations to support

fixes #137479
fixes #136922

* Bump aiohttp to 3.11.12 (#137494)

changelog: aio-libs/aiohttp@v3.11.11...v3.11.12

* Bump govee-ble to 0.43.0 to fix compat with new H5179 firmware (#137508)

changelog: Bluetooth-Devices/govee-ble@v0.42.1...v0.43.0

fixes #136969

* Bump habiticalib to v0.3.5 (#137510)

* Fix Mill issue, where no sensors were shown (#137521)

Fix mill issue #137477

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>

* Don't overwrite setup state in async_set_domains_to_be_loaded (#137547)

* Use separate metadata files for onedrive (#137549)

* Fix sending polls to Telegram threads (#137553)

Fix sending poll to Telegram thread

* Skip building wheels for electrickiwi-api (#137556)

* Add excluded domains to broadcast intent (#137566)

* Revert "Add `PaddleSwitchPico` (Pico Paddle Remote) device trigger to Lutron Caseta" (#137571)

* Fix Overseerr webhook configuration JSON (#137572)

Co-authored-by: Lars Jouon <[email protected]>

* Do not rely on pyserial for port scanning with the CM5 + ZHA (#137585)

Do not rely on pyserial for port scanning with the CM5

* Bump eheimdigital to 1.0.6 (#137587)

* Bump pyfireservicerota to 0.0.46 (#137589)

* Bump reolink-aio to 0.11.10 (#137591)

* Allow to omit the payload attribute to MQTT publish action to allow an empty payload to be sent by default (#137595)

Allow to omit the payload attribute to MQTT publish actionto allow an empty payload to be sent by default

* Handle previously migrated HEOS device identifier (#137596)

* Bump `aioshelly` to version `12.4.1` (#137598)

* Bump aioshelly to 12.4.0

* Bump to 12.4.1

* Bump electrickiwi-api  to 0.9.13 (#137601)

* bump ek api version to fix deps

* Revert "Skip building wheels for electrickiwi-api (#137556)"

This reverts commit 5f6068e.

---------

Co-authored-by: Marc Mueller <[email protected]>

* Bump ZHA to 0.0.48 (#137610)

* Bump Electrickiwi-api to 0.9.14 (#137614)

* bump library to fix bug with post

* rebuild

* Update google-nest-sdm to 7.1.3 (#137625)

* Update google-nest-sdm to 7.1.2

* Bump nest to 7.1.3

* Don't use the current temperature from Shelly BLU TRV as a state for External Temperature number entity (#137658)

Introduce RpcBluTrvExtTempNumber for External Temperature entity

* Fix LG webOS TV turn off when device is already off (#137675)

* Bump version to 2025.2.1

---------

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Michael Arthur <[email protected]>
Co-authored-by: Joostlek <[email protected]>
Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: G Johansson <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: Manu <[email protected]>
Co-authored-by: Daniel Hjelseth Høyer <[email protected]>
Co-authored-by: Josef Zweck <[email protected]>
Co-authored-by: Jasper Wiegratz <[email protected]>
Co-authored-by: Michael Hansen <[email protected]>
Co-authored-by: Dennis Effing <[email protected]>
Co-authored-by: Lars Jouon <[email protected]>
Co-authored-by: puddly <[email protected]>
Co-authored-by: Sid <[email protected]>
Co-authored-by: Ron <[email protected]>
Co-authored-by: starkillerOG <[email protected]>
Co-authored-by: Jan Bouwhuis <[email protected]>
Co-authored-by: Andrew Sayre <[email protected]>
Co-authored-by: Maciej Bieniek <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: Allen Porter <[email protected]>
Co-authored-by: Shay Levy <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload failed for onedrive.ea093e654287a17c: Backup operation failed
3 participants