-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play disconnect sound android #113
base: master
Are you sure you want to change the base?
Conversation
…anager in constructor of TwilioVoiceManager.java to since wav file needs time to parsed. use of intantiated soundPoolManager also seems to result in better sound quality for other SoundPoolManager related tasks such as ringing, etc
Nice improvement, I will look at merging this PR after other PR that have precedence, because they implement Twilio new libraries. |
Sounds good [pun intended]. 👍 |
Thank you for your PR and our apologies it has been quiet on this PR for so long. Please read #158 for a general update on what's happening in this repo. I have a few questions about this PR:
Many thanks for your efforts! |
It's been so long since I've worked on this that I'm not entirely sure what the best answer is to your first question but it sounds like a fine solution. With my current workload, I don't have time to work on this. |
@gentleShark I understand! No worries, for now I will add this PR as a backlog item so it can be merged eventually. Thanks for your efforts! I will leave this open for now. |
changes to play disconnect.wav on disconnect(). instantiated soundPoolManager in constructor of TwilioVoiceManager.java since .wav file needs time to be loaded and parsed per Android Dev recommendation. Instantiated soundPoolManager in the constructor also seems to result in better sound quality for other SoundPoolManager related tasks compared to creating an instance at runtime with SoundPoolManager.getInstance(getReactApplicationContext()). I also added a few generated files to .gitignore