add download count tracking for infinite you. #1335
Conversation
YuminJia
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
| repoName: "InfiniteYou", | ||
| repoUrl: "https://github.com/bytedance/InfiniteYou", | ||
| filter: false, | ||
| countDownloads: `path_extension:"bin" OR path_extension:"safetensors"`, |
There was a problem hiding this comment.
Counting on all bin and safetensors files means that a user downloading the full repo will count as multiple downloads, which we want to avoid. Is it possible to decide of a single file that would be the reference for the download rule?
There was a problem hiding this comment.
Hi @Wauplin , thanks for your comments! Our repo has two versions of our model, where downloading either of them should consider downloading of our model. If we want to reduce the multiple download counts, we can replace the path_extension:"bin" OR path_extension:"safetensors" with path_extension:"bin". Please let us know your suggestion. Thanks a lot! Here is our model repo structure: https://huggingface.co/ByteDance/InfiniteYou/tree/main
There was a problem hiding this comment.
If there are two ways to download a model, I would suggest to count downloads on a specific file for each ways.
There was a problem hiding this comment.
For instance, if user wants to download from safetensors files, we could count downloads based on infu_flux_v1.0/sim_stage1/InfuseNetModel/diffusion_pytorch_model-00001-of-00002.safetensors.
Or is it that the 2 .bin files are mandatory for either of the 2 ways (so either infu_flux_v1.0/aes_stage2/image_proj_model.bin or infu_flux_v1.0/sim_stage1/image_proj_model.bin must be downloaded to instantiate the model)? If that's the case, I would prefer to have both files explicitly named in the download count rule if that's fine with you. Let me know your thoughts!
There was a problem hiding this comment.
@Wauplin Yes, image_proj_model.bin must be downloaded for either version of our models, and we only have two .bin files for the two versions of our model. Therefore, we used path_extension:"bin".
There was a problem hiding this comment.
@Wauplin Could you please review it again and let us know your thoughts? Thanks!
| repoName: "InfiniteYou", | ||
| repoUrl: "https://github.com/bytedance/InfiniteYou", | ||
| filter: false, | ||
| countDownloads: `path_extension:"bin"`, |
There was a problem hiding this comment.
| countDownloads: `path_extension:"bin"`, | |
| countDownloads: `path:"infu_flux_v1.0/sim_stage1/image_proj_model.bin" OR path:"infu_flux_v1.0/aes_stage2/image_proj_model.bin"`, |
I still prefer to be explicit on the file paths, even if there are only 2 .bin files. Otherwise looks good 👍
|
Merged! Expect 2-3 days before getting it live on the Hub 🤗 |
Thank you so much! |
No description provided.