Skip to content

add download count tracking for infinite you. #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 10 commits into from
Apr 8, 2025
Merged

add download count tracking for infinite you. #1335

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06da555
add download count tracking for infinite you.
YuminJia Apr 2, 2025
5ca8696
Merge branch 'main' into yumin/add-download-counter
YuminJia Apr 2, 2025
7da4820
update label.
YuminJia Apr 2, 2025
022bb8a
udpate order.
YuminJia Apr 2, 2025
5949381
Merge branch 'main' into yumin/add-download-counter
YuminJia Apr 2, 2025
4174a33
only track bin files.
YuminJia Apr 3, 2025
9e63084
Merge branch 'yumin/add-download-counter' of github.com:YuminJia/hugg…
YuminJia Apr 3, 2025
891a74a
Merge branch 'main' into yumin/add-download-counter
YuminJia Apr 3, 2025
14d2263
Merge branch 'main' into yumin/add-download-counter
YuminJia Apr 7, 2025
bd113fb
Update packages/tasks/src/model-libraries.ts
Wauplin Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
repoUrl: "https://github.com/DigitalPhonetics/IMS-Toucan",
countDownloads: `path:"embedding_gan.pt" OR path:"Vocoder.pt" OR path:"ToucanTTS.pt"`,
},
"infinite-you": {
prettyLabel: "InfiniteYou",
repoName: "InfiniteYou",
repoUrl: "https://github.com/bytedance/InfiniteYou",
filter: false,
countDownloads: `path_extension:"bin" OR path_extension:"safetensors"`,
Copy link
Copy Markdown
Contributor

@Wauplin Wauplin Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counting on all bin and safetensors files means that a user downloading the full repo will count as multiple downloads, which we want to avoid. Is it possible to decide of a single file that would be the reference for the download rule?

Copy link
Copy Markdown

@EndlessSora EndlessSora Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wauplin , thanks for your comments! Our repo has two versions of our model, where downloading either of them should consider downloading of our model. If we want to reduce the multiple download counts, we can replace the path_extension:"bin" OR path_extension:"safetensors" with path_extension:"bin". Please let us know your suggestion. Thanks a lot! Here is our model repo structure: https://huggingface.co/ByteDance/InfiniteYou/tree/main

Copy link
Copy Markdown
Contributor

@Wauplin Wauplin Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are two ways to download a model, I would suggest to count downloads on a specific file for each ways.

Copy link
Copy Markdown
Contributor

@Wauplin Wauplin Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance, if user wants to download from safetensors files, we could count downloads based on infu_flux_v1.0/sim_stage1/InfuseNetModel/diffusion_pytorch_model-00001-of-00002.safetensors.

Or is it that the 2 .bin files are mandatory for either of the 2 ways (so either infu_flux_v1.0/aes_stage2/image_proj_model.bin or infu_flux_v1.0/sim_stage1/image_proj_model.bin must be downloaded to instantiate the model)? If that's the case, I would prefer to have both files explicitly named in the download count rule if that's fine with you. Let me know your thoughts!

Copy link
Copy Markdown

@EndlessSora EndlessSora Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wauplin Yes, image_proj_model.bin must be downloaded for either version of our models, and we only have two .bin files for the two versions of our model. Therefore, we used path_extension:"bin".

Copy link
Copy Markdown

@EndlessSora EndlessSora Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wauplin Could you please review it again and let us know your thoughts? Thanks!

Copy link
Copy Markdown
Contributor

@Wauplin Wauplin Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1335 (comment)

},
keras: {
prettyLabel: "Keras",
repoName: "Keras",
Expand Down